m4sterchain commented on code in PR #221: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/221#discussion_r2278530256
########## build_optee_libraries.sh: ########## @@ -41,7 +41,7 @@ export CROSS_COMPILE64="aarch64-linux-gnu-" # build optee_os and optee_client for qemu_v8 git clone https://github.com/OP-TEE/optee_os.git -b $OPTEE_VERSION $OPTEE_DIR/optee_os -(cd $OPTEE_DIR/optee_os && make PLATFORM=vexpress-qemu_armv8a) +(cd $OPTEE_DIR/optee_os && make PLATFORM=vexpress-qemu_armv8a CFG_TA_FLOAT_SUPPORT=n) Review Comment: Thanks for outlining the underlying issue, and I agree with the proposed actions. I suggest inlining the reason for this change directly as a comment in the script for future maintenance, rather than keeping it only in the commit message. This will make it clearer for anyone reading the build scripts later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
