DemesneGH commented on PR #232:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/232#issuecomment-3323169152
Updated to remove all `STD` checks from TA's Makefile, tested building on
dev docker image.
-----
BTW:
> * The design principle for the makefile is using the caller provided
variable
I see TA's Makefile both uses the caller provided variable (TARGET,
CROSS_COMPILE) and directly read from env (TA_DEV_KIT_DIR).
TA_DEV_KIT_DIR is used by optee-utee-sys/build.rs and TA's Makefile. In
optee-utee-sys/build.rs:
```
fn link() {
let optee_os_dir = env::var("TA_DEV_KIT_DIR").unwrap();
let search_path = Path::new(&optee_os_dir).join("lib");
```
I'm not sure if we should follow the "caller provided variable" principle or
it can be read from global env in TA's Makefile.
Also, I'm wondering if we follow the "caller provided variable" principle,
seems no need to set the global env var for setup, because they may be read by
any low-level Makefiles, which may introduce inconsistency and complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
