DemesneGH commented on code in PR #237: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/237#discussion_r2425584261
########## Dockerfile.dev: ########## @@ -19,6 +19,7 @@ FROM ubuntu:24.04 AS no-std-build-env # Base environment ENV TEACLAVE_TOOLCHAIN_BASE=/opt/teaclave +ENV OPTEE_VERSION=4.7.0 Review Comment: The ENV is already set in line 31-32, used by https://github.com/apache/teaclave-trustzone-sdk/blob/main/scripts/release/build_dev_docker.sh which reads the optee version from `optee-version.txt` and build the image. It keeps the consistency (the only source of optee version is the txt) and avoids manually edit the docker file for each optee release. FYI the other code which reads the optee version is: https://github.com/apache/teaclave-trustzone-sdk/blob/main/build_optee_libraries.sh#L22 Please consider the usecase and decide if this line should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
