asir66 commented on PR #245: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/245#issuecomment-3585624878
> Hi @asir66 thanks for the effort. Please take my previous comment ([#245 (comment)](https://github.com/apache/teaclave-trustzone-sdk/pull/245#discussion_r2473250351) compare the current `cargo optee` subcommand with existing `cargo` conventions. If possible, could you help list all the areas where the current implementation violates or diverges from standard cargo behavior? Once we have this list, we can decide whether to fix them within this PR or address them in a series of follow-up PRs before publishing to crates.io. > > A few highlights from my earlier comment for reference: > > * Project configuration should stay in each project’s Cargo.toml. Toolchain configuration (e.g., ta-dev-kit-dir) should be managed by a dedicated subcommand such as `cargo optee setup`, instead of being mixed into project config. > * std / no_std selection should be inferred automatically from the active feature set, consistent with how existing cargo workflows behave. > > Thanks in advance. I’ll do my best to review these areas and put together a comprehensive list of the differences from standard cargo conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
