ivila commented on code in PR #261:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/261#discussion_r2605467420
##########
optee-teec/optee-teec-sys/build.rs:
##########
@@ -18,6 +18,47 @@
use std::env::{self, VarError};
use std::path::PathBuf;
+const ENV_OPTEE_CLIENT_EXPORT: &str = "OPTEE_CLIENT_EXPORT";
+const AARCH64: &str = "aarch64-unknown-linux-gnu";
Review Comment:
The targets aren’t limited to `aarch64-unknown-linux-gnu` and
`x86_64-unknown-linux-gnu`. They can also include `arm-unknown-linux-gnueabihf`
(see:
[arm-unknown-optee.json](https://github.com/apache/teaclave-trustzone-sdk/blob/main/arm-unknown-optee.json))
and other variants, such as `aarch64-unknown-none` for `no_std` tests. It
would be better to detect the architecture from the target triple rather than
relying on the entire triple string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
