ivila commented on PR #265: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/265#issuecomment-3717172605
> @ivila Sorry for missing your message, a bit busy these days... > > The PR looks good for me, and the reorganization of mock features makes a lot of sense. Thanks for the effort! > > I've tested it locally with optee-utee's object tests: > > ``` > $ cargo test --package optee-utee --lib -- object::persistent_object::tests --nocapture > ... > running 4 tests > test object::persistent_object::tests::test_create_and_drop ... ok > test object::persistent_object::tests::test_create_and_failed_close_delete ... ok > test object::persistent_object::tests::test_create_and_successfully_close_delete ... ok > test object::persistent_object::tests::test_create_failed ... ok > > test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 10 filtered out; finished in 0.00s > ``` > > Two more considerations: > > * Could you please add a simple doc in `docs/` regarding the mock's background and usage, like "OP-TEE Modules Unit Testing with Mocks"? Having a reference would be very helpful for other contributors who are willing to develop the optee modules. > * Consider adding this unit test into our CI jobs? > Could you please add a simple doc Yes, will do > Consider adding this unit test into our CI jobs Yes, adding it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
