DemesneGH commented on PR #268: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/268#issuecomment-3727527295
Thanks for the PR! Introducing an option for the linking method is a good improvement and the code looks good to me. However, since this introduces a new implicit environment variable, could you help add some documentation in https://github.com/apache/teaclave-trustzone-sdk/blob/main/docs/advanced-setup.md? A new section like "## Linkage Method to OP-TEE C Libraries" would be good to explain how to use TEEC_STATIC to control the linking method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
