TheButlah commented on code in PR #278:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/278#discussion_r2803476525
##########
examples/serde-rs/ta/src/main.rs:
##########
@@ -68,16 +68,17 @@ fn invoke_command(cmd_id: u32, params: &mut Parameters) ->
Result<()> {
// Ensure the buffer is large enough to hold the serialized data.
let len = bytes.len();
- if len > buffer.len() {
+ if len > buffer.capacity() {
trace_println!("Buffer too small, cannot copy all bytes");
+ p.request_more_capacity(len).expect("infallible");
Review Comment:
I think that approach makes sense! I've updated the PR
##########
examples/serde-rs/ta/src/main.rs:
##########
@@ -68,16 +68,17 @@ fn invoke_command(cmd_id: u32, params: &mut Parameters) ->
Result<()> {
// Ensure the buffer is large enough to hold the serialized data.
let len = bytes.len();
- if len > buffer.len() {
+ if len > buffer.capacity() {
trace_println!("Buffer too small, cannot copy all bytes");
+ p.request_more_capacity(len).expect("infallible");
Review Comment:
I think that approach is a big improvement! I've updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
