Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/2#discussion_r77899606
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
@@ -41,14 +41,15 @@
@Override
protected void configure() {
+ // some of these classes need to be non-singleton in order to create a
new instance during leader() in
+ // TransactionService
bind(SnapshotCodecProvider.class).in(Singleton.class);
-
bind(TransactionStateStorage.class).annotatedWith(Names.named("persist"))
- .to(HDFSTransactionStateStorage.class).in(Singleton.class);
-
bind(TransactionStateStorage.class).toProvider(TransactionStateStorageProvider.class).in(Singleton.class);
+
bind(TransactionStateStorage.class).annotatedWith(Names.named("persist")).to(HDFSTransactionStateStorage.class);
+
bind(TransactionStateStorage.class).toProvider(TransactionStateStorageProvider.class);
- bind(TransactionManager.class).in(Singleton.class);
-
bind(TransactionSystemClient.class).to(TransactionServiceClient.class).in(Singleton.class);
-
bind(MetricsCollector.class).to(DefaultMetricsCollector.class).in(Singleton.class);
+ bind(TransactionManager.class);
--- End diff --
This binding looks redundant now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
