[ 
https://issues.apache.org/jira/browse/TEPHRA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472239#comment-15472239
 ] 

ASF GitHub Bot commented on TEPHRA-176:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/4#discussion_r77928500
  
    --- Diff: tephra-examples/cdh-5.8/pom.xml ---
    @@ -0,0 +1,96 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one
    +  ~ or more contributor license agreements.  See the NOTICE file
    +  ~ distributed with this work for additional information
    +  ~ regarding copyright ownership.  The ASF licenses this file
    +  ~ to you under the Apache License, Version 2.0 (the
    +  ~ "License"); you may not use this file except in compliance
    +  ~ with the License.  You may obtain a copy of the License at
    +  ~
    +  ~      http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~ Unless required by applicable law or agreed to in writing, software
    +  ~ distributed under the License is distributed on an "AS IS" BASIS,
    +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  ~ See the License for the specific language governing permissions and
    +  ~ limitations under the License.
    +  -->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +  <parent>
    +    <artifactId>tephra-examples</artifactId>
    +    <groupId>org.apache.tephra</groupId>
    +    <version>0.9.0-incubating-SNAPSHOT</version>
    +  </parent>
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <artifactId>tephra-examples-cdh-5.8</artifactId>
    +  <name>Apache Tephra Examples For CDH 5.8</name>
    +
    +  <repositories>
    +    <repository>
    +      <id>cloudera</id>
    +      
<url>https://repository.cloudera.com/artifactory/cloudera-repos/</url>
    +    </repository>
    +  </repositories>
    +
    +  <properties>
    +    <hadoop.version>2.6.0-cdh5.8.0</hadoop.version>
    +    <hbase12cdh.version>1.2.0-cdh5.8.0</hbase12cdh.version>
    +  </properties>
    +
    +  <build>
    +    <sourceDirectory>../src/main/java</sourceDirectory>
    +    <testSourceDirectory>../src/test/java</testSourceDirectory>
    +  </build>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.tephra</groupId>
    +      <artifactId>tephra-hbase-compat-1.2-cdh</artifactId>
    --- End diff --
    
    Now that I think about it, it would be better to add a separate compat 
modules for CDH 5.7 and CDH 5.8. Since we now avoid code duplication for compat 
modules, it is just one extra jar we need to publish.


> Add support for CDH 5.8
> -----------------------
>
>                 Key: TEPHRA-176
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-176
>             Project: Tephra
>          Issue Type: New Feature
>            Reporter: Poorna Chandra
>            Assignee: Shankar Selvam
>             Fix For: 0.9.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to