Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/23#discussion_r91465579
  
    --- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -348,27 +348,30 @@ private void cleanupTimedOutTransactions() {
             }
     
             long currentTime = System.currentTimeMillis();
    -        List<Long> timedOut = Lists.newArrayList();
    +        Map<Long, InProgressType> timedOut = Maps.newHashMap();
    --- End diff --
    
    How about the "write lock" comment? Currently we are only holding the read 
lock and modifying the invalid list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to