Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/29#discussion_r98780450
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
 ---
    @@ -209,6 +212,31 @@ public void destroy() {
         }
       }
     
    +  /**
    +   * Create the prune state table given the {@link TableName} if the table 
doesn't exist already.
    +   *
    +   * @param stateTable prune state table name
    +   */
    +  protected void createPruneTable(TableName stateTable) throws IOException 
{
    +    try (Admin admin = this.connection.getAdmin()) {
    +      HTableDescriptor htd = new HTableDescriptor(stateTable);
    +      htd.addFamily(new 
HColumnDescriptor(DataJanitorState.FAMILY).setMaxVersions(1));
    +      admin.createTable(htd);
    --- End diff --
    
    Since this happens on all regions on every startup, I think it would be 
better to check for existence first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to