Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102348469
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -1123,15 +1112,14 @@ private boolean doTruncateInvalidTxBefore(long
time) throws InvalidTruncateTimeE
}
// Find all invalid transactions earlier than truncateWp
- Set<Long> toTruncate = Sets.newHashSet();
- for (long wp : invalid) {
- // invalid list is sorted, hence can stop as soon as we reach a wp
>= truncateWp
- if (wp >= truncateWp) {
- break;
+ LongSet toTruncate = new LongArraySet();
+ for (long wp : invalidTxList.toRawList()) {
--- End diff --
Unfortunately using the normal for-each loop means there would be boxing.
To avoid boxing, you have to use the iterator directly
```java
LongIterator it = invalidTxList.toRawList().iterator();
while (it.hasNext()) {
long wp = it.nextLong();
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
