[ https://issues.apache.org/jira/browse/TEPHRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879123#comment-15879123 ]
ASF GitHub Bot commented on TEPHRA-224: --------------------------------------- Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/38#discussion_r102559503 --- Diff: tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java --- @@ -57,8 +60,13 @@ public void run() { Transaction tx = txManager.startShort(); txManager.abort(tx); + if (tx.getInvalids().length == 0) { + LOG.info("Invalid list is empty, not running transaction pruning"); --- End diff -- I have filed TEPHRA-225 for to handle this > Handle delay between transaction max lifetime check and data writes while > pruning > --------------------------------------------------------------------------------- > > Key: TEPHRA-224 > URL: https://issues.apache.org/jira/browse/TEPHRA-224 > Project: Tephra > Issue Type: Sub-task > Reporter: Poorna Chandra > Assignee: Poorna Chandra > Fix For: 0.12.0-incubating > > > Transaction pruning relies on inactive transaction bound (a bound that says > at a given time there will be no transactions smaller than inactive > transaction bound that can still be writing data). To determine the inactive > transaction bound for a given time, TEPHRA-199 introduced transaction maximum > lifetime. > However there can be a delay between the transaction max lifetime being > enforced and the write reaching HBase. Hence it would be good to use a buffer > to pad the transaction max lifetime when pruning. -- This message was sent by Atlassian JIRA (v6.3.15#6346)