Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/45#discussion_r126789926 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java --- @@ -56,17 +58,24 @@ private static final byte[] secondaryIndexQualifier = Bytes.toBytes('r'); private static final byte[] DELIMITER = new byte[] {0}; - public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, HTableInterface hTable, - byte[] secondaryIndex) { + public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, Table hTable, + byte[] secondaryIndex) throws IOException { secondaryIndexTableName = TableName.valueOf(hTable.getName().getNameAsString() + ".idx"); - HTable secondaryIndexHTable = null; - try (HBaseAdmin hBaseAdmin = new HBaseAdmin(hTable.getConfiguration())) { + Table secondaryIndexHTable = null; + Connection conn = null; + try { + conn = ConnectionFactory.createConnection(hTable.getConfiguration()); + Admin hBaseAdmin = conn.getAdmin(); if (!hBaseAdmin.tableExists(secondaryIndexTableName)) { hBaseAdmin.createTable(new HTableDescriptor(secondaryIndexTableName)); } - secondaryIndexHTable = new HTable(hTable.getConfiguration(), secondaryIndexTableName); - } catch (Exception e) { + secondaryIndexHTable = conn.getTable(secondaryIndexTableName); + } catch (Exception e) { --- End diff -- Extra space at the end of the line causes the following warning when the [patch](https://github.com/apache/incubator-tephra/pull/45.patch) for this PR is applied - ``` 45.patch:49: trailing whitespace. try { 45.patch:58: trailing whitespace. } catch (Exception e) { 45.patch:298: trailing whitespace. warning: 3 lines add whitespace errors. ``` Can you remove the extra spaces?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---