Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/48#discussion_r136458250
  
    --- Diff: 
tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TTransactionServer.java
 ---
    @@ -68,6 +68,8 @@
     
         public TBoolean canCommitTx(TTransaction tx, Set<ByteBuffer> changes) 
throws TTransactionNotInProgressException, org.apache.thrift.TException;
     
    +    public TBoolean canCommitOrThrow(TTransaction tx, Set<ByteBuffer> 
changes) throws TTransactionNotInProgressException, TGenericException, 
org.apache.thrift.TException;
    --- End diff --
    
    please do not review this file, it is generated by Thrift. Only need to 
review transaction.thrift


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to