mengw15 commented on code in PR #3736:
URL: https://github.com/apache/texera/pull/3736#discussion_r2355957649
##########
core/gui/src/app/common/type/user.ts:
##########
@@ -44,6 +47,7 @@ export interface User
googleAvatar?: string;
comment: string;
lastLogin?: number;
Review Comment:
is this (lastLogin) also fall into Second or Millisecond? maybe keep in same
style as accountCreation?
##########
core/gui/src/app/common/service/user/auth.service.ts:
##########
@@ -153,7 +153,7 @@ export class AuthService {
googleId: this.jwtHelperService.decodeToken(token).googleId,
googleAvatar: this.jwtHelperService.decodeToken(token).googleAvatar,
role: role,
- comment: this.jwtHelperService.decodeToken(token).comment,
+ comment: this.jwtHelperService.decodeToken(token).comment
Review Comment:
since there is no change in this file, maybe try to keep this line as the
previous one. keep this pull request cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
