kunwp1 commented on code in PR #3754: URL: https://github.com/apache/texera/pull/3754#discussion_r2371238877
########## deployment/examples/setup_example_workflows.sh: ########## Review Comment: ditto ########## deployment/examples/setup_example_datasets.sh: ########## Review Comment: Could we add brief docs for each setup script: what it does and when to run it? ########## deployment/examples/workflows/[Example] Data Exploration on Movies Dataset.json: ########## Review Comment: Right now we keep two example workflows as hard-coded JSON in the repo. If the workflow JSON spec changes, these files can silently break. To avoid regressions, could we adopt one of these approaches? 1. Generate on setup: Dynamically create the two example JSONs from the current schema or a small generator during the setup script. 2. Enforce consistency in CI: Add a guard that fails when the JSON spec (or template) changes without updating the example workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
