Copilot commented on code in PR #3776:
URL: https://github.com/apache/texera/pull/3776#discussion_r2384391810
##########
core/gui/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -85,6 +85,9 @@ export class ExecuteWorkflowService {
current: ExecutionStateInfo;
}>();
+ private regionStream = new Subject<string>();
+
+
Review Comment:
[nitpick] Excessive blank lines (two consecutive empty lines). Consider
using a single blank line for consistency with the rest of the codebase."
```suggestion
```
##########
core/gui/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -99,6 +102,9 @@ export class ExecuteWorkflowService {
) {
workflowWebsocketService.websocketEvent().subscribe(event => {
switch (event.type) {
+ case "RegionUpdateEvent":
+ this.regionStream.next(event.Regions)
Review Comment:
Missing semicolon after `this.regionStream.next(event.Regions)`.
JavaScript/TypeScript statements should end with semicolons for consistency
with the codebase style."
```suggestion
this.regionStream.next(event.Regions);
```
##########
core/gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts:
##########
@@ -323,6 +323,13 @@ export class WorkflowEditorComponent implements
AfterViewInit, OnDestroy {
});
}
});
+
+ this.executeWorkflowService
+ .getRegionStream()
+ .pipe(untilDestroyed(this))
+ .subscribe(region => {
+ console.log(region)
Review Comment:
Debug console.log statement should be removed from production code. Consider
using proper logging or removing this temporary debugging code."
```suggestion
// region update received; add handling logic here if needed
```
##########
core/gui/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -329,6 +335,12 @@ export class ExecuteWorkflowService {
return this.executionStateStream.asObservable();
}
+ public getRegionStream(): Observable<string> {
+ return this.regionStream.asObservable();
+ }
+
+
+
Review Comment:
[nitpick] Excessive blank lines (two consecutive empty lines). Consider
using a single blank line for consistency with the rest of the codebase."
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
