GitHub user aglinxinyuan edited a comment on the discussion: Enforce PR template compliance and require related issue/discussion reference
I’m not against this idea. My concern is about the decision-making process. If we are considering a project-wide change, especially one that affects every contributor’s workflow, it should go through a formal voting process. This is not about which approach is “correct,” which one is “better,” or what other projects are doing. When we change a practice that impacts everyone, it’s important to gather and consider everyone’s input. I also dislike enforcing this requirement through our own GitHub Action. The implementation in https://github.com/apache/texera/pull/4228 feels somewhat hacky and relies on HTML parsing and regex, which can easily become outdated. If we want to ensure that PRs reference issues, reviewers can verify this, or we can consider using a well-maintained third-party action. Maintaining around 100 lines of custom code in our repository for such a simple check does not seem ideal. GitHub link: https://github.com/apache/texera/discussions/4246#discussioncomment-15952658 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
