[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928399#action_12928399 ]
Roger Meier commented on THRIFT-916: ------------------------------------ e.g. the following ones: {code} ../../../lib/cpp/src/protocol/TVirtualProtocol.h:44: warning: unused parameter 'name' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:44: warning: unused parameter 'messageType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:44: warning: unused parameter 'seqid' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:54: warning: unused parameter 'name' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:66: warning: unused parameter 'name' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:66: warning: unused parameter 'fieldType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:66: warning: unused parameter 'fieldId' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:76: warning: unused parameter 'keyType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:76: warning: unused parameter 'valType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:76: warning: unused parameter 'size' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:86: warning: unused parameter 'elemType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:86: warning: unused parameter 'size' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:96: warning: unused parameter 'elemType' ../../../lib/cpp/src/protocol/TVirtualProtocol.h:96: warning: unused parameter 'size' {code} > gcc warnings in c++ header files > -------------------------------- > > Key: THRIFT-916 > URL: https://issues.apache.org/jira/browse/THRIFT-916 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.4 > Reporter: Piotr Bartosiewicz > Assignee: Roger Meier > Attachments: make-k.log, THRIFT-916_Wall_pedantic__noerrors.patch, > v1-fix-format-strings.patch, v1-fix-java-style-and-warnings.patch, > v1-fix-random-silly-warnings.patch, v2-fix-all-warnings.patch, > v3-fix-all-warnings.patch, v4-fix-all-warnings.patch > > > I tried to add an extra gcc warning options in my project but a number of > warnings was emmited from thrift headers. > Following the boost library recommendations, code should be clean with "-Wall > -Wextra -pedantic" options. > Currently only with -Wall thrift has no warnings. > Other options worth considering (but require more work) are -Wconversion > -Wold-style-cast > So the task is to improve the thrift headers. > I suggest also update all the thrift makefiles so the thrift sources an tests > will indicate the faulty code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.