I personally always use -Wall -Werror, so I prefer that one, but together we may still be in the minority :)
-Anthony On Wed, Nov 17, 2010 at 04:53:25PM -0500, Christian Lavoie wrote: > Yeah, -Wextra and -Werror together are a bad idea -- I'd rather have > -Wall and -Werror personally, but I suspect I'll be in a minority. > > On Wed, Nov 17, 2010 at 4:51 PM, Piotr Bartosiewicz (JIRA) > <j...@apache.org> wrote: > > > > [ > > https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933179#action_12933179 > > ] > > > > Piotr Bartosiewicz commented on THRIFT-916: > > ------------------------------------------- > > > > I set "-Wall -Wextra" only. Without this patches this 'errors' are only > > 'warnings', but Christian's patch adds -Werror which tels gcc to treat > > warnings as error. > > The [^THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch] can be commited. > > > >> gcc warnings in c++ header files > >> -------------------------------- > >> > >> Key: THRIFT-916 > >> URL: https://issues.apache.org/jira/browse/THRIFT-916 > >> Project: Thrift > >> Issue Type: Improvement > >> Components: C++ - Library > >> Affects Versions: 0.4 > >> Reporter: Piotr Bartosiewicz > >> Assignee: Roger Meier > >> Attachments: DebianLenny_error.log, make-k.log, > >> THRIFT-916_Wall_pedantic__noerrors.patch, > >> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch, > >> v1-enable-wall-werror.patch, v1-fix-format-strings.patch, > >> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch, > >> v1-fix-random-silly-warnings.patch, v2-fix-all-warnings.patch, > >> v3-fix-all-warnings.patch, v4-fix-all-warnings.patch > >> > >> > >> I tried to add an extra gcc warning options in my project but a number of > >> warnings was emmited from thrift headers. > >> Following the boost library recommendations, code should be clean with > >> "-Wall -Wextra -pedantic" options. > >> Currently only with -Wall thrift has no warnings. > >> Other options worth considering (but require more work) are -Wconversion > >> -Wold-style-cast > >> So the task is to improve the thrift headers. > >> I suggest also update all the thrift makefiles so the thrift sources an > >> tests will indicate the faulty code. > > > > -- > > This message is automatically generated by JIRA. > > - > > You can reply to this email to add a comment to the issue online. > > > > > > > > -- > Have fun, Christian > http://linkedin.christianlavoie.net > > "I won't let you fall apart." -- ------------------------------------------------------------------------ Anthony Molinaro <antho...@alumni.caltech.edu>
