[ 
https://issues.apache.org/jira/browse/THRIFT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933792#action_12933792
 ] 

Alexander Shigin commented on THRIFT-252:
-----------------------------------------

{code}
-  DecodeBuffer input = {};
+  DecodeBuffer input; // = {}; does not compile on msvc
{code}

I think you do need to zero the input buffer. If the decode_buffer_from_obj 
can't get stringiobuf, it will free DecodeBuffer this some garbage in 
refill_callable. Does MSVC compile {{input = {0, 0};}}?

> Python libraries unable to build with MSVC on Windows
> -----------------------------------------------------
>
>                 Key: THRIFT-252
>                 URL: https://issues.apache.org/jira/browse/THRIFT-252
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Python - Library
>         Environment: Windows XP or Vista, Visual C++ 2008 (and likely others)
>            Reporter: Michael Greene
>            Assignee: Michael Greene
>         Attachments: thrift-252-python-msvc-1.diff, thrift-python-msvc.diff
>
>
> This patch adds support for Visual C++ on Windows to the Python libraries.  
> stdbool and stdint are not available on MSVC, so alternates were defined.  
> netinet is replaced with winsock2.
> Additionally, setup.py is updated to support this platform and with the 
> latest project information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to