[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Lavoie updated THRIFT-916:
------------------------------------
Attachment: v4-enable-wall-werror.patch
Fixes David's concerns (and, despite the name, does NOT enable -Werror anymore).
Works great on Mac OS X:
{noformat}
Darwin -- 10.5.0 Darwin Kernel Version 10.5.0: Fri Nov 5 23:20:39 PDT 2010;
root:xnu-1504.9.17~1/RELEASE_I386 i386
i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
flex 2.5.35
{noformat}
Tested on Debian sid (x86 and amd64) -- raises a new type-punning related
warning that I suspect we want to take care of soon; if my understanding is
correct the optimizer isn't guaranteed to be correct while this is popping up:
{noformat}
../../../lib/cpp/src/protocol/TBinaryProtocol.tcc:377: warning: dereferencing
type-punned pointer will break strict-aliasing rules
{noformat}
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: DebianLenny_error.log, make-k.log,
> THRIFT-916_Wall_pedantic__noerrors.patch,
> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch,
> v1-enable-wall-werror.patch, v1-fix-format-strings.patch,
> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch,
> v1-fix-random-silly-warnings.patch, v1-long-long-to-int64_t.patch,
> v2-enable-wall-werror.patch, v2-fix-all-warnings.patch,
> v3-enable-wall-werror.patch, v3-fix-all-warnings.patch,
> v4-enable-wall-werror.patch, v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
