[
https://issues.apache.org/jira/browse/THRIFT-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-998.
--------------------------------
Resolution: Fixed
Rich,
committed your patch. => minus 5 warnings
There are still 60 Warnings....
However -Wswitch (enabled via -Wall) should be sufficient for most cases.
> Silence g++ -Wswitch-enum warning in header
> -------------------------------------------
>
> Key: THRIFT-998
> URL: https://issues.apache.org/jira/browse/THRIFT-998
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Rich Salz
> Assignee: Roger Meier
> Attachments: diff.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This small patch silence's G++ about -Wswitch-enum. I don't use
> switch-default as it gives too many false positives. Using break and a return
> outside the switch makes the code still work even if more enum's are added
> and the G++ warning isn't seen or is ignored.
> This is related to the work started in THRIFT-916
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
