[
https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978942#action_12978942
]
T Jake Luciani commented on THRIFT-1033:
----------------------------------------
First, thanks for this great work!
I think you should be contributing the whole of the project as in the /lib
stuff for this to be useful.
Also, the tests and examples should go in there too.
I'm not a node users so I'm not sure what is needed to run your example but
some instructions in a README would be helpful.
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Reporter: Wade Simmons
> Attachments: thrift_nodejs.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it
> compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this
> patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple
> months and we haven't run into any major bugs that haven't already been
> fixed. I've also been chatting with someone who found the code on github and
> is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift
> server).
> Let me know if you have any questions or concerns! I would love to see this
> make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
