[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Donham closed THRIFT-1047.
-------------------------------
Resolution: Not A Problem
OK, I did not know about Thrift.type_checking, thanks.
Honestly this seems like a pretty dangerous option, particularly since the
default seems to be false. But I understand the performance need. Perhaps a
safer approach might be to allow type-checking to be turned off in particular
invocations of a constructor. Anyway, closing the bug.
> rb_thrift_memory_buffer_write treats arg as string without check, segfaults
> if you pass non-string
> --------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1047
> URL: https://issues.apache.org/jira/browse/THRIFT-1047
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.5
> Reporter: Jake Donham
>
> I think there should be a call to Check_Type(str, T_STRING) in there
> VALUE rb_thrift_memory_buffer_write(VALUE self, VALUE str) {
> VALUE buf = GET_BUF(self);
> rb_str_buf_cat(buf, RSTRING_PTR(str), RSTRING_LEN(str));
> return Qnil;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
