-1 I'll re-roll with the changes mentioned below plus a critical performance bug in c# that should go out.
On Fri, Jan 28, 2011 at 5:27 PM, Mark Slee <ms...@fb.com> wrote: > Ticket opened and patch committed to trunk. Ready for a merge into the 0.6 > release. > > https://issues.apache.org/jira/browse/THRIFT-1051 > Committed revision 1064911. > > Cheers, > mcslee > > -----Original Message----- > From: Bryan Duxbury [mailto:br...@rapleaf.com] > Sent: Friday, January 28, 2011 2:17 PM > To: dev@thrift.apache.org > Subject: Re: [VOTE] Thrift 0.6.0 RC1 > > Mind opening a ticket? > > On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote: > > > -1, just a minor issue. I'm +1 if we nuke the @Override causing problems > > below. > > > > The Java compile failed for me due to a bad @Override annotation on an > > interface rather than an abstract class. I'm running Java 1.5. According > to > > Stack Overflow: > > > > "But don't forget that Java Compiler 1.5 will not allow this annotation > > when overriding interface methods... Some IDEs, as Eclipse, even > configured > > with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 > and > > don't allow the use @override as described above." > > > > compile: > > [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build > > [javac] > > > /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186: > > method does not override a method from its superclass > > [javac] @Override > > [javac] ^ > > [javac] Note: Some input files use unchecked or unsafe operations. > > [javac] Note: Recompile with -Xlint:unchecked for details. > > [javac] 1 error > > > > BUILD FAILED > > /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the > compiler > > error output for details. > > > > This is the code in question -- I think we should nuke this @Override to > > ensure the project builds on Java 1.5. Everything else looks fine. > > > > /** Comparator used in TreeSet */ > > private static class TAsyncMethodCallTimeoutComparator implements > > Comparator<TAsyncMethodCall> { > > @Override > > public int compare(TAsyncMethodCall left, TAsyncMethodCall right) { > > > > > > -----Original Message----- > > From: Christian Lavoie [mailto:christian.lav...@gmail.com] > > Sent: Thursday, January 27, 2011 7:55 PM > > To: dev@thrift.apache.org > > Subject: Re: [VOTE] Thrift 0.6.0 RC1 > > > > +1 > > > > Haskell works, and the whole thing compiles (and make checks) on Mac OS X > > 10.6. > > > > On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts > > <mathias.herbe...@gmail.com> wrote: > > > +1 > > > > > > My GWT patch was successfully updated for this RC. > > > > > > > > > > > -- > > Have fun, Christian > > http://linkedin.christianlavoie.net > > > > "I won't let you fall apart." > > >
