[
https://issues.apache.org/jira/browse/THRIFT-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996870#comment-12996870
]
Christian Lavoie commented on THRIFT-625:
-----------------------------------------
Hey Aalok -- you need to upload an SVN patch to JIRA (it's simpler for us to
patch in the code from tools we're use to, but it also gets you to record that
you're allowing the ASF to license the code under its usual license, which is
required to contribute the code).
I've tested the code (btw, there's a bug in your patch in the t_go_generator.cc
file; see http://codereview.appspot.com/4168058/patch/1/5 ; but I used the one
off your github repository to test things).
Generally speaking looks okay -- but the integration with the make system is a
bit off. In particular, I tried 'make check' in lib/go and got:
{{make: *** No rule to make target `check'. Stop.}}
Regardless, it needs to be uploaded here as a patch to be commitable. The
simplest way to do that is using {{svn diff}} to generate a file, and attach it
to THRIFT-625.
> Add support for 'Go'
> --------------------
>
> Key: THRIFT-625
> URL: https://issues.apache.org/jira/browse/THRIFT-625
> Project: Thrift
> Issue Type: Wish
> Reporter: Mathias Herberts
> Attachments: go-language-support-4thrift.diff
>
>
> Add code generation for 'Go' http://golang.org/
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
