[
https://issues.apache.org/jira/browse/THRIFT-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997942#comment-12997942
]
David Reiss commented on THRIFT-1067:
-------------------------------------
The original author of the extension module had this to say:
It's been so long since I dealt with PHP internals that I'm not sure I can
do a good job of validating this patch -- and that's not exactly something
I'm eager to pick up again.
That being said: the ZTS stuff and the memory leak fix in
protocol_writeMessageBegin look probably OK. The exception stuff is also
probably OK. I would make sure that the #include and typedef stuff at the
top to work around Windows' lack of the [u]intXX_t typedefs and some of
the networking headers didn't break the build on UNIXy machines. Not sure
what the correct behaviour is for the changes to the T_[UI]64 conversions.
Given that it's PHP and we're dealing with 64 bit values, it's probably
all undefined behaviour anyway.
> Tons of bugs in php implementation
> ----------------------------------
>
> Key: THRIFT-1067
> URL: https://issues.apache.org/jira/browse/THRIFT-1067
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.6
> Reporter: ruslan.usifov
> Assignee: ruslan.usifov
> Fix For: 0.7
>
> Attachments: php20110219.patch
>
>
> PHP version of thrift hold many bugs:
> 1). Incorrect work with ZTS
> 2). Hung when work throw thrift framed transport
> 3). Memleak in protocol_writeMessageBegin
> 4). Hung when server close connection, and when php code try reuse same
> connection
> 5). Impossible pass really long values on 32 bit platforms
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
