[
https://issues.apache.org/jira/browse/THRIFT-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998476#comment-12998476
]
Rich Salz commented on THRIFT-1070:
-----------------------------------
Here's one clump. We use -Werror so warnings are fatal errors for us.
cc1plus: warnings being treated as errors
In file included from
/home/belindat/workspace/stage/include/bedrock/private/thriftUtils.hpp:17,
from applianceUtils.cpp:35:
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h: In
member function ‘virtual const uint8_t*
apache::thrift::transport::TBufferBase::borrow(uint8_t*, uint32_t*)’:
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h:97:
error: conversion to ‘unsigned int’ from ‘long int’ may alter its value
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h: In
member function ‘void
apache::thrift::transport::TMemoryBuffer::getBuffer(uint8_t**, uint32_t*)’:
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h:518:
error: conversion to ‘unsigned int’ from ‘long int’ may alter its value
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h: In
member function ‘uint32_t
apache::thrift::transport::TMemoryBuffer::available_read() const’:
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h:605:
error: conversion to ‘uint32_t’ from ‘long int’ may alter its value
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h: In
member function ‘uint32_t
apache::thrift::transport::TMemoryBuffer::available_write() const’:
/home/belindat/workspace/stage/include/thrift/transport/TBufferTransports.h:609:
error: conversion to ‘uint32_t’ from ‘long int’ may alter its value
make[2]: Leaving directory `/home/belindat/workspace/src/lib/sdk'
make[2]: *** [applianceUtils.o] Error 1
make[1]: *** [sdk.build] Error 2
make: *** [lib.build] Error 2
make[1]: Leaving directory `/home/belindat/workspace/src/lib'
> C++ compiler and runtime have 32/64bit problems
> -----------------------------------------------
>
> Key: THRIFT-1070
> URL: https://issues.apache.org/jira/browse/THRIFT-1070
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.6
> Reporter: Rich Salz
> Attachments: jira1070.pch
>
>
> When compiling thrift with a 64bit G++ and a strict set of warnings, some
> errors come up. The code assumes that sizeof(size_t)==sizeof(int32_t).
> Since most of these problems are related to the wire protocol, which defines
> a four-byte size, the fixes are straightforward casting.
> We'll provide a patch shortly.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
