On Thu, Feb 24, 2011 at 1:59 PM, Diwaker Gupta <[email protected]> wrote: > Is there a documented (or at least well understood) development > process for Thrift? In particular: > > * How is code reviewed? I've seen people attach patches to Jira, but > thats not very convenient and makes the review process cumbersome and > less transparent.
Attachments to JIRA are (I believe) required for licensing reasons -- there's an explicit step in the upload process to assign copyright to the ASF, and the code is not to be committed without the proper assignment. > I noticed some people using > http://codereview.appspot.com/. What do people feel about a dedicated > ReviewBoard or Gerrit instance? People are welcomed to use any tool they want before submitting a patch, but see above as to why that step is as it is right now. Personally, I'm old school and don't care much for fancy web UIs. > * Is there a style/formatting guide for the code? "Match the code in the files you're modifying" for the compiler and common libs, and "Stay close to community-accepted standards" for specific bindings. So no, no official document. > * Most of the development seems to be driven by Jira issues. Is there > any prioritization or roadmap on top of that? We all try to fix critical bugs when raised to our attention; so far it's a best-effort project. Facebook cares a fair bit about C++ and Java performance, so those areas get improved regularly. I do my best to handle Haskell issues (especially patches) as fast as practical (constraints on personal time aside), and other volunteers do the same in their areas of interest. We tend to cut release after it's been a while, when changes warrant it. -- Have fun, Christian http://linkedin.christianlavoie.net "I won't let you fall apart."
