[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001522#comment-13001522 ]
Nicholas Telford commented on THRIFT-638: ----------------------------------------- My major concern is that I can't find an effective way to run the existing test suite (for PHP at least). Specifically, in order to run the ThriftTest client tests, I need to run a ThriftTest server, For what it's worth, I've managed to test this patch with both TBufferedTransport and TFramedTransport (with the patch in THRIFT-867) with my own set of homebrew scripts. I'm pretty confident about it, but I'd feel better with a complete test suite. That's something I may work on tomorrow if I get the chance. > BufferedTransport + C extensions block until recv timeout is reached on last > fread call > --------------------------------------------------------------------------------------- > > Key: THRIFT-638 > URL: https://issues.apache.org/jira/browse/THRIFT-638 > Project: Thrift > Issue Type: Bug > Components: PHP - Library > Affects Versions: 0.2 > Reporter: Chris Goffinet > Fix For: 0.7 > > Attachments: 0001-Replace-freads-with-stream_socket_recvfrom.patch, > 0002-tocket-read-meta-data-check.diff, thrift-tsocket-638-0002.patch, > thrift-tsocket-638-0003.patch, thrift-tsocket-638.patch > > > I wanted to throw this out if any other folks experience this later on. At > Digg we've been using the BufferedTransport + C extension of Thrift in PHP. > Every so often, we will see spikes in latency increases on RPC calls that we > know have acceptable response times (<200ms). This seems to happen based on > how much data is being sent back over the wire. This is more of a PHP > problem, but can be corrected in Thrift's PHP library for folks who don't > want to upgrade PHP. I am still waiting to see if it's corrected in later > versions (we use 5.2.9). > http://bonsai.php.net/bug.php?id=42720 > Replacing the fread statements in TSocket.php with stream_socket_recvfrom > correct this behavior so that calls do not wait until they hit the recv > timeout. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira