[
https://issues.apache.org/jira/browse/THRIFT-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-1014:
--------------------------------
Attachment: THRIFT-1014_JavaScript_lint_fixes.patch
fix errors found by lint:
{noformat}
$ gjslint --nojsdoc lib/js/thrift.js
1 files checked, no errors found.
{noformat}
> Thrift JavaScript code should use semicolon-terminated statements
> -----------------------------------------------------------------
>
> Key: THRIFT-1014
> URL: https://issues.apache.org/jira/browse/THRIFT-1014
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, JavaScript - Library
> Reporter: James Hamlin
> Priority: Minor
> Attachments: THRIFT-1014_JavaScript_lint_fixes.patch
>
>
> It's good style to terminate all JavaScript statements with a semicolon.
> Thrift's JavaScript library and generated JavaScript don't use semicolons at
> all. Beyond the stylistic improvement, fixing up the syntax would make
> Thrift's JavaScript compatible with certain JavaScript linters, e.g. Google
> Closure's.
> I have a patch that's about ready if the project will take contributions.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
