[ 
https://issues.apache.org/jira/browse/THRIFT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-867.
--------------------------------

    Resolution: Fixed

I just committed this to trunk.

> PHP accelerator module's output transport is incompatible with 
> TFramedTransport
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-867
>                 URL: https://issues.apache.org/jira/browse/THRIFT-867
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.4
>            Reporter: Bryan Duxbury
>             Fix For: 0.7
>
>         Attachments: thrift-867.diff, thrift-tframedtransport-867.patch
>
>
> I think we've figured out the cause of everyone's problems with THRIFT-837. 
> The patch itself is fine; however, in fixing that bug, we've exposed the fact 
> that PHPOutputTransport erroneously calls down to the underlying PHP 
> transport's flush() method every time the internal 8k buffer is flushed. This 
> is fine for the buffered transport, but unacceptable for the framed 
> transport, which should only be flushed once per RPC call.
> It seems like what we need to do is separate the "internal" buffer flushes 
> from the "external" transport flushes. If we do that, everything should work 
> out fine.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to