[ 
https://issues.apache.org/jira/browse/THRIFT-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torben Brodt updated THRIFT-1098:
---------------------------------

    Description: 
missing underscore in variablename. Thrift PHP SimpleServer ist not running 
without this fix.

PHP Notice:  Undefined property: TBinaryProtocolFactory::$strictRead in 
/usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 
406
PHP Notice:  Undefined property: TBinaryProtocolFactory::$strictWrite in 
/usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 
406

  was:
missing underscore in variablename. Thrift PHP SimpleServer ist not running 
without this fix.

thats the fix:

Index: src/protocol/TBinaryProtocol.php
===================================================================
--- src/protocol/TBinaryProtocol.php    (Revision 1083148)
+++ src/protocol/TBinaryProtocol.php    (Arbeitskopie)
@@ -403,7 +403,7 @@
   }
 
   public function getProtocol($trans) {
-    return new TBinaryProtocol($trans, $this->strictRead, $this->strictWrite);
+    return new TBinaryProtocol($trans, $this->strictRead_, 
$this->strictWrite_);
   }
 }


added patch as file. removed inline patch

> Undefined properties in TBinaryProtocolFactory
> ----------------------------------------------
>
>                 Key: THRIFT-1098
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1098
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.6
>         Environment: all php versions
> (appropiate for users running a php server)
>            Reporter: Torben Brodt
>            Priority: Critical
>              Labels: TBinaryProtocolFactory, php, simpleserver
>         Attachments: patch.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> missing underscore in variablename. Thrift PHP SimpleServer ist not running 
> without this fix.
> PHP Notice:  Undefined property: TBinaryProtocolFactory::$strictRead in 
> /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on 
> line 406
> PHP Notice:  Undefined property: TBinaryProtocolFactory::$strictWrite in 
> /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on 
> line 406

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to