[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014167#comment-13014167 ]
Roger Meier commented on THRIFT-1031: ------------------------------------- Good job! I have one concern, the dependency on *apr*. I'm very happy to have another runtime dependency for Thrift. We use Thrift on *very small systems* and do not like to pull in additional dependencies. We need just need a little subset of APR. Are there any other alternatives to achieve this? > Patch to compile Thrift for vc++ 9.0 and 10.0 > --------------------------------------------- > > Key: THRIFT-1031 > URL: https://issues.apache.org/jira/browse/THRIFT-1031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows XP 32bit, vc++ 9.0, 10.0 > Reporter: James Dickson > Priority: Trivial > Fix For: 0.7 > > Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch > > > At our company we need clients running on Windows being able to connect to > our linux servers running hypertable. The attached patch enables the parts > needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or > 10.0 compilers. > Having read previous posts about ports using boost::asio we found these to be > too intrusive for our needs. This version uses pthreads_win32 and winsock2 > and is as designed to be as un-intrusive as is possible to the original unix > code base. It is mostly #defines between unix sockets and winsock2 sockets. > We also tried to follow the folder structuring of the C# runtime that has > visual studio solutions to be consistent. > More details are in the README as not all the functionality of the original > unix code base is available to windows users. We will add the missing > functionality, we just wanted to share what we had as for a Windows based > client for us it is sufficient. > The patch is based on the latest revision in SVN, we would love feedback and > any code reviews. If there is any possibility of this being added to the main > trunk then that would be much appreciated, however we don't expect that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira