[ https://issues.apache.org/jira/browse/THRIFT-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nevo Hed updated THRIFT-1130: ----------------------------- Attachment: bool.patch Not sure if this is the best fix, but seems to be rather minimalistic By the way - this is my first attempt at contribution here, please let me know if there is some other procedure should be followed. > Add the ability to specify symbolic default value for optional boolean > ---------------------------------------------------------------------- > > Key: THRIFT-1130 > URL: https://issues.apache.org/jira/browse/THRIFT-1130 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Affects Versions: 0.5, 0.6 > Reporter: Nevo Hed > Priority: Minor > Attachments: bool.patch > > > When specifying a default value for an optional struct member of the type > bool the user now needs to enter a numeric value (0, or 1). It would be nice > if they could specify a symbolic value such as 'true' & 'false' > {quote} > Example thrift file: > struct AtscStrmRecordRequestT { > 1: optional bool bDoSomething = true, > 2: required string whatever; > } > {quote} > With current error > {quote} > $ /opt/thrift-0.6.0/compiler/cpp/thrift --gen cpp /rtmp/x.thrift > [ERROR:/rtmp/x.thrift:2] (last token was 'true') > Cannot use reserved language keyword: "true" > {quote} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira