[ 
https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021782#comment-13021782
 ] 

Michael Stockton commented on THRIFT-1108:
------------------------------------------

We've tried to keep thrift working with 1.8 and 1.9. I think your patch would 
need to include support for both to be accepted. If you look at the gem I 
referenced, it merely adds nonblocking methods to OpenSSL::SSL::SSLSocket. You 
can use the RUBY_VERSION constant to conditionally require openssl-nonblock.

If you include a test case in your patch which fails, it may be easier for me 
to see the problem you're having. Again, for inclusion, we'd ideal want SSL 
support to work with each transport.



> SSL support for the Ruby library 
> ---------------------------------
>
>                 Key: THRIFT-1108
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1108
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.6
>            Reporter: Alex
>            Priority: Minor
>              Labels: ssl
>         Attachments: ssl_support.diff
>
>
> Attached are modified versions of the socket and server_socket files which 
> include SSL support. I do not consider these implementations complete, 
> however they work well for my purposes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to