[
https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024965#comment-13024965
]
Rush Manbert commented on THRIFT-591:
-------------------------------------
Carl is correct in general. If the patch were brought up to date and applied to
the tree, then all existing C++ users could configure so that nothing changes
for them. They would use the same classes as before, which would use the same
underlying code. No boost threads and no ASIO involved. We configure it so that
the TSocket, etc. classes are synonyms for TAsioSocket and friends, so we use
the original class names but the ASIO implementation, as well as Boost threads.
That's so that we run the same configurations on Mac and Windows.
The patch also had fixes for many of the C++ tests (particularly the stress
test) as well as the scheduler. Those might be somewhat controversial.
> Make the C++ runtime library be compatible with Windows and Visual Studio
> -------------------------------------------------------------------------
>
> Key: THRIFT-591
> URL: https://issues.apache.org/jira/browse/THRIFT-591
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Library
> Environment: Windows XP and above, Visual Studio 2005 and above
> Reporter: Rush Manbert
> Attachments: MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch,
> MsvcPatchSupportScripts.zip,
> THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log,
> ThriftMsvcPatchForSvnRev818530.txt.zip, thrift-818530-patched.zip,
> thriftWindowsRev818530BugFix.zip
>
>
> Modify the C++ runtime library to be compatible with Windows and able to be
> built by Visual Studio.
> The work has been done and a patch is available. I will attach it soon.
> Note that this issue and the attached patch supercedes the patches that I
> wrongly attached to JIRA 311. That issue is about making the C++ library
> support async client/server interaction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
