[ 
https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045749#comment-13045749
 ] 

Toby Thain edited comment on THRIFT-633 at 6/8/11 1:50 AM:
-----------------------------------------------------------

The bug is certainly still there with javac 1.5.0_19 and OS X 10.4.11.

Another problem under 1.5 is that IOException does not have the constructor 
used by Thrift code.

With the annotations removed, and the IOExceptions constructed using the 
parameter-less constructor, the code for simonsays.thrift appears to build okay:

# makefile fragment, thrift 0.6.1
gen-java/SimonSays.java : simonsays.thrift
        thrift -r --gen java $<
        sed -i.bak -e /@Override/d -e 's/IOException(te)/IOException()/' $@

It is unfortunate that 1.5 is not supported. Perhaps it should be a separate 
language target?


      was (Author: qu1j0t3):
    The bug is certainly still there with javac 1.5.0_19 and OS X 10.4.11.

Another problem under 1.5 is that IOException does not have the constructor 
used by Thrift code.

With the annotations removed, and the IOExceptions constructed using the 
parameter-less constructor, the code appears to build okay.

(  sed -e /@Override/d -e 's/IOException(te)/IOException()/'  )

It is unfortunate that 1.5 is not supported. Perhaps it should be a separate 
language target?

  
> Generated code has @Override annotations which won't compile using Apple's 
> JDK 1.5
> ----------------------------------------------------------------------------------
>
>                 Key: THRIFT-633
>                 URL: https://issues.apache.org/jira/browse/THRIFT-633
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>         Environment: Mac OS X Tiger/Leopard JDK 1.5
>            Reporter: Mathias Herberts
>
> Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with 
> error:
>     [javac] 
> /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251:
>  method does not override a method from its superclass
>     [javac]   @Override
>     [javac]    ^

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
  • [jira] [Issue Comment Edit... Toby Thain (JIRA)

Reply via email to