[ https://issues.apache.org/jira/browse/THRIFT-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061077#comment-13061077 ]
Pascal Bach commented on THRIFT-1232: ------------------------------------- I agree it is probably best to make user defined exceptions inherit directly from JavaScripts Error. But I belive the Mozilla example you show is wrong. DerivedException = function(args) { this.name = 'DerivedException'; ... } DerivedException.prototype = Error.prototype; > JavaScript TException should be a constructor function > ------------------------------------------------------ > > Key: THRIFT-1232 > URL: https://issues.apache.org/jira/browse/THRIFT-1232 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library > Reporter: Pascal Bach > Priority: Minor > Labels: exception-handling, js > > The JavaScript TException is declared as an object with a prototype property > assigned to it. > It should be declared as a constructor function with a prototype. Otherwise > exceptions derived from TException using Thrift.inherits are not instances of > TException. > Example: > function DerivedException() {}; > Thrift.inherits(DerivedException, Thrift.TException); > var ex = new DerivedException(); > ex instanceof Thrift.TException // => Error as TException is not a function -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira