[ 
https://issues.apache.org/jira/browse/THRIFT-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068451#comment-13068451
 ] 

Jake Farrell commented on THRIFT-1241:
--------------------------------------

Thanks Darius, initial work looks great. Will want to change from namespace53 
to just namespace since php5.3+ will have this option available and php5.4 is 
in rc right now so no sense in defining a specific version in the option. Can 
you attach this as a patch with asf inclusion please.

> php namespace generation
> ------------------------
>
>                 Key: THRIFT-1241
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1241
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.7
>         Environment: PHP 5.3
>            Reporter: Darius Staisiunas
>              Labels: patch
>             Fix For: 0.7
>
>
> Patch is based mainly on https://issues.apache.org/jira/browse/THRIFT-777, 
> but some more improvements:
> namespace can be specified with dots '.' like for every other language
> for example:
> namespace php com.onego.thrift
> would generate in php file
> namespace com\onego\thrift
> to generate php files with namespaces use:
> thrift --gen php:namespace53 example.thrift

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to