[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073001#comment-13073001
]
Roger Meier commented on THRIFT-916:
------------------------------------
I think we should not use {{-Werror}} on trunk, this will break builds on new
platfroms or compilers.
The trunk build should always build and run all unittests. It sends a mail to
the dev list if it fails.
https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift/
I suggest fixing the 2 compiler warnings visible within Thrift-cpp CI job:
https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift-cpp/
Afterwards I will add the -Werror to that CI job and activate the mail of build
failures to the dev mailing list.
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: DebianLenny_error.log,
> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_pedantic__noerrors.patch, THRIFT-916_fix_no-overflow.patch,
> make-k.log, v1-enable-wall-werror.patch, v1-fix-format-strings.patch,
> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch,
> v1-fix-random-silly-warnings.patch, v1-long-long-to-int64_t.patch,
> v2-enable-wall-werror.patch, v2-fix-all-warnings.patch,
> v3-enable-wall-werror.patch, v3-fix-all-warnings.patch,
> v4-enable-wall-werror.patch, v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
