[ https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086436#comment-13086436 ]
Wade Simmons commented on THRIFT-1267: -------------------------------------- I wonder if we should instead make a backwards incompatible change for the 0.8 release and change the callback style to match the rest of Node.js: callback(err, result). instead of the current: callback(result). > Node.js can't throw exceptions. > -------------------------------- > > Key: THRIFT-1267 > URL: https://issues.apache.org/jira/browse/THRIFT-1267 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Compiler > Affects Versions: 0.7 > Reporter: Hans Duedal > Labels: compiler, javascript, node, nodejs > Fix For: 0.7 > > Attachments: nodejs-exception.patch > > > There is no way as far as I can tell for node.js servers to throw thrift > exceptions. > I have made a patch to allow it to throw exceptions. It lets the node.js > server implementation give params directly to the result object, thereby > being able to specify the exception. It doesn't affect normal (non exception) > return data. > Test case: https://gist.github.com/1151782 > Install thrift module "npm install thrift", generate thrift "thrift --gen > js:node test.thrift" and run server then client. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira