thrift: handle undeclared exceptions in the async
-------------------------------------------------

                 Key: THRIFT-1269
                 URL: https://issues.apache.org/jira/browse/THRIFT-1269
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Compiler, C++ - Library
            Reporter: Dave Watson
            Priority: Minor


>From 25366c3648ef4c2d436641a2051c057abde05975 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <simpk...@fb.com>
Date: Wed, 6 Jan 2010 02:10:19 +0000
Subject: [PATCH 01/33] thrift: handle undeclared exceptions in the async
 error cob

Summary:
This updates the generated TAsyncProcessor code to correctly handle when
an undeclared exception type is passed into an error callback.  It now
sends back a T_EXCEPTION message to the client, just like the non-async
code does.  Previously the exception wouldn't be handled, causing the
TEventWorker thread to exit.


Test Plan:
Tested changing the async sort tutorial to pass in a generic TException
rather than a SortError, and verified that the client correctly received
an exception.




Conflicts:

        compiler/cpp/src/generate/t_cpp_generator.cc
---
 compiler/cpp/src/generate/t_cpp_generator.cc |   38 +++++++++++++++++++++----
 1 files changed, 32 insertions(+), 6 deletions(-)


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to