[ https://issues.apache.org/jira/browse/THRIFT-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091165#comment-13091165 ]
Hudson commented on THRIFT-1293: -------------------------------- Integrated in Thrift #235 (See [https://builds.apache.org/job/Thrift/235/]) THRIFT-1293. cpp: improve handling of exceptions thrown by process() Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1161660 Files : * /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp * /thrift/trunk/lib/cpp/src/server/TSimpleServer.cpp * /thrift/trunk/lib/cpp/src/server/TThreadPoolServer.cpp * /thrift/trunk/lib/cpp/src/server/TThreadedServer.cpp > thrift: improve handling of exceptions thrown by > -------------------------------------------------- > > Key: THRIFT-1293 > URL: https://issues.apache.org/jira/browse/THRIFT-1293 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Reporter: Dave Watson > Assignee: Dave Watson > Priority: Minor > Fix For: 0.8 > > Attachments: > 0019-thrift-improve-handling-of-exceptions-thrown-by-proc.patch > > > From 68ed500b994bbe3beeb2eb66e052c6af7ef3a72c Mon Sep 17 00:00:00 2001 > From: Adam Simpkins <simpk...@fb.com> > Date: Tue, 6 Apr 2010 20:59:29 +0000 > Subject: [PATCH 19/33] thrift: improve handling of exceptions thrown by > process() > Summary: > Update the server code to print the exeption message for any > std::exception that is thrown by process(), and not just TExceptions. > Also print the exception type in the message. > Test Plan: > Used it to debug some broken code that was throwing std::length_error. > (That turned out to just be a race condition in some of my test code.) > Revert Plan: > OK > --- > lib/cpp/src/server/TNonblockingServer.cpp | 25 ++++++++++++++----------- > lib/cpp/src/server/TSimpleServer.cpp | 8 ++++---- > lib/cpp/src/server/TThreadPoolServer.cpp | 11 ++++------- > lib/cpp/src/server/TThreadedServer.cpp | 8 ++++---- > 4 files changed, 26 insertions(+), 26 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira