[
https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1286:
---------------------------------
Attachment: thrift-1286.patch
Updated patch that allows for either bundler or rake to build the ruby client.
Configure script now checks for Bundler availability to allow ci servers to
build successfully. Dependencies are automatically handled via Bundler and the
thrift.gemspec. Removes dependency on echoe.
> Modernize the Thrift Ruby Library Dev Environment
> -------------------------------------------------
>
> Key: THRIFT-1286
> URL: https://issues.apache.org/jira/browse/THRIFT-1286
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.7, 0.8
> Reporter: Scott Gonyea
> Assignee: Jake Farrell
> Fix For: 0.7, 0.8
>
> Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch,
> thrift-1286.patch
>
>
> This fixes the ruby libraries environment. This introduces Bundler for
> managing the development environment, as well as in handling the Gem release
> process. Echoe is no longer present.
> The end result is that the development environment is easier to setup and
> easier to reproduce. Thus, easier to contribute to.
> This structures the spec folder to better follow conventions RSpec.
> The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec
> 2. This brings everything into the land of RSpec 2. Some additional cleanup
> could definitely be done, but this gets us out of the deprecation warnings
> and other weird behavior-ings.
> To run this in CI, however that is done, you'll effectively want the shell
> script (or whatever) to look like this:
> which bundle || gem install bundler
> bundle install
> bundle exec rake spec
> Patch should be pulled from:
> https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b
> or up to the commit:
> https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
