[ 
https://issues.apache.org/jira/browse/THRIFT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated THRIFT-1299:
---------------------------------

    Attachment: thrift-1299.patch

configure.ac AC_CHECK_LIBS are necessary only for the clients use. 

LIBS = -lssl -lcrypto -lpthread

The following patch removes the dependencies added from configure.ac in the 
thrift compiler makefile compiler/cpp/Makefile

> If SSL is available, 'thrift' binary links against it
> -----------------------------------------------------
>
>                 Key: THRIFT-1299
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1299
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, C++ - Compiler, C++ - Library
>    Affects Versions: 0.7
>            Reporter: Diwaker Gupta
>            Assignee: Jake Farrell
>            Priority: Minor
>         Attachments: thrift-1299.patch
>
>
> Inspection of compiler/cpp/Makefile and lib/cpp/Makefile reveals that for 
> building both the thrift compiler as well as the C++ libraries, the same set 
> of libraries (in the variable LIBS) are used. When OpenSSL is available, this 
> has the unintended consequence that the thrift compiler links libssl (and 
> potentially libcrypto), even though it doesn't need to. In theory there is no 
> harm in linking against additional shared libraries but it can be an issue in 
> practice. Specifically, if OpenSSL etc are installed in a custom location 
> (such as when building a custom toolchain), the thrift binary will fail to 
> run unless LD_LIBRARY_PATH is set every time thrift needs to run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to