[
https://issues.apache.org/jira/browse/THRIFT-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093050#comment-13093050
]
Hudson commented on THRIFT-1301:
--------------------------------
Integrated in Thrift #241 (See [https://builds.apache.org/job/Thrift/241/])
THRIFT-1301. cpp: consolidate common code in TNonblockingServer constructors
Patch: Adam Simpkins
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162920
Files :
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
> thrift: consolidate common code in TNonblockingServer
> -------------------------------------------------------
>
> Key: THRIFT-1301
> URL: https://issues.apache.org/jira/browse/THRIFT-1301
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0021-consolidate-common-code-2.patch
>
>
> From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <[email protected]>
> Date: Fri, 16 Apr 2010 01:28:36 +0000
> Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
> constructors
> Summary:
> This moves most of the code in the initializer lists into a helper
> function. I'm about to make a change that will double the number of
> constructors, and I'd rather not have to copy-and-paste these long
> initializers.
> Test Plan:
> Ran the tests from [fb unit test], and everything passes.
> Revert Plan:
> OK
> ---
> lib/cpp/src/server/TNonblockingServer.h | 125 ++++++++++++------------------
> 1 files changed, 50 insertions(+), 75 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
